Skip to content

Conversation

@RafaelKayumov
Copy link
Contributor

@RafaelKayumov RafaelKayumov commented Sep 8, 2025

WOOMOB-1271

Description

Makes sure that the "Split Shipments" feature is not visible for CIAB sites

  • Conditionally hides the pencil icon
  • Conditionally hides the "Split Shipments" row that's displayed when no shipments yet created.
  • Renamed splitShipmentsAvailable -> splitShipmentsRowVisible WooShippingCreateLabelsViewModel. The new splitShipmentsRowVisible accounts CIAB site restrictions.
  • Added editSplitShipmentsOptionVisible to WooShippingCreateLabelsViewModel that's determines the pencil icon visibility in shipments panel.
  • Added MockCIABEligibilityChecker for testing purposes

The majority of changes come from WooShippingCreateLabelsViewModelTests.swift updates

Non-CIAB site testing case (default behaviour)

  • Use a site with shipping plugin active. Make sure the site doesn't contain "garden" or "ciab" in name (this is the temp CIAB / non-CIAB site distinguishing logic).
  • Find an order that contains a single shipment with multiple products / items to have the split shipments feature applicable.
  • Navigate to the order details
  • Navigate to the "Create Shipping Label" flow
  • Make sure the "Split shipments" button is displayed next to "Products"
Снимок экрана 2025-09-10 в 15 00 10
  • Find another order that already contains several unfulfilled shipments
  • Navigate to order details -> "Create Shipping Label"
  • Make sure the "pencil" icon is displayed in shipments tab
Снимок экрана 2025-09-10 в 15 04 00

CIAB site testing case

  • Add "garden" or "ciab" into site name in admin dashboard
  • Restart the app and make sure the name change took place
  • Repeat steps from Non-CIAB scenario
  • Make "Split shipments" and "pencil" buttons are not visible.
Снимок экрана 2025-09-10 в 15 11 19 Снимок экрана 2025-09-10 в 15 12 39

Testing information

Tested the above scenarios on iPhone Simulator 18.4.


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@RafaelKayumov RafaelKayumov added this to the 23.3 milestone Sep 8, 2025
@RafaelKayumov RafaelKayumov changed the title [CIAB Hide split shipments for CIAB sites [CIAB] Hide split shipments for CIAB sites Sep 8, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 8, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16105-1882771
Version23.2
Bundle IDcom.automattic.alpha.woocommerce
Commit1882771
Installation URL2uvnhpobm4v10
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@RafaelKayumov RafaelKayumov force-pushed the WOOMOB-1271-hide-split-shipments-for-ciab branch from ee23b0a to 1882771 Compare September 9, 2025 21:51
Base automatically changed from WOOMOB-1268-indentify-CIAB-sites to trunk September 10, 2025 09:41
@RafaelKayumov RafaelKayumov marked this pull request as ready for review September 10, 2025 12:14
@itsmeichigo itsmeichigo self-assigned this Sep 11, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that splitting shipments / edit shipments appear correctly for both CIAB and non-CIAB sites. Code changes look good 👍 🚢

@RafaelKayumov RafaelKayumov merged commit 8eaabf7 into trunk Sep 11, 2025
19 checks passed
@RafaelKayumov RafaelKayumov deleted the WOOMOB-1271-hide-split-shipments-for-ciab branch September 11, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants